Sebastien Lorquet sebastien@lorquet.fr [nuttx]
2018-01-22 10:53:07 UTC
hello
upgrading from 7.20 to 7.23 (we were eaten by this issue)
in nsh_parse.c at line 1172 np_flags is being read inconditionnally (this is the
only usage in this file, there may be more)
however in apps/nshlib/nsh.h
np_flags is not defined if CONFIG_NSH_DISABLESCRIPT=y
This is also present in the master branch.
CONFIG_NSH_DISABLESCRIPT is active in my configuration. For the moment I worked
this around by allowing scripting.
I dont know if the np_flags should be enabled with less restrictive conditions,
or if the tests should be protected by the config.
Can you please fix this? Sorry I dont have one, I need your input for a rational
decision.
Sebastien
upgrading from 7.20 to 7.23 (we were eaten by this issue)
in nsh_parse.c at line 1172 np_flags is being read inconditionnally (this is the
only usage in this file, there may be more)
however in apps/nshlib/nsh.h
np_flags is not defined if CONFIG_NSH_DISABLESCRIPT=y
This is also present in the master branch.
CONFIG_NSH_DISABLESCRIPT is active in my configuration. For the moment I worked
this around by allowing scripting.
I dont know if the np_flags should be enabled with less restrictive conditions,
or if the tests should be protected by the config.
Can you please fix this? Sorry I dont have one, I need your input for a rational
decision.
Sebastien